This repository was archived by the owner on Apr 15, 2026. It is now read-only.
security(hooks): suppress imager output to prevent secret leakage - #52
Merged
Conversation
The Talos imager prints the full profile to stdout, which includes the embedded machine configuration containing certificates and private keys. This was being logged in CI, exposing sensitive cluster secrets. Fix: Redirect stdout to /dev/null while keeping stderr for errors. Also removed -t flag as TTY allocation is not needed in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
/dev/nullto suppress profile output-tflag (TTY allocation not needed in CI)Important: Secret Rotation Required
The Talos cluster secrets that were logged in previous CI runs are now compromised and should be rotated before deploying the cluster. This can be done by regenerating
talsecret.sops.yamlwith:🤖 Generated with Claude Code