Skip to content
This repository was archived by the owner on Apr 15, 2026. It is now read-only.

security(hooks): suppress imager output to prevent secret leakage - #52

Merged
jmgilman merged 1 commit into
masterfrom
fix/suppress-imager-secrets
Dec 29, 2025
Merged

security(hooks): suppress imager output to prevent secret leakage#52
jmgilman merged 1 commit into
masterfrom
fix/suppress-imager-secrets

Conversation

@jmgilman

Copy link
Copy Markdown
Collaborator

Summary

  • Fix security issue where Talos imager printed full machine configuration (including certificates and private keys) to stdout
  • The imager's verbose profile output was being captured in CI logs, exposing cluster secrets

Changes

  • Redirect imager stdout to /dev/null to suppress profile output
  • Keep stderr for actual error messages
  • Remove -t flag (TTY allocation not needed in CI)

Important: Secret Rotation Required

The Talos cluster secrets that were logged in previous CI runs are now compromised and should be rotated before deploying the cluster. This can be done by regenerating talsecret.sops.yaml with:

cd infrastructure/compute/talos
talhelper gensecret > talsecret.sops.yaml
sops -e -i talsecret.sops.yaml

🤖 Generated with Claude Code

The Talos imager prints the full profile to stdout, which includes the
embedded machine configuration containing certificates and private keys.
This was being logged in CI, exposing sensitive cluster secrets.

Fix: Redirect stdout to /dev/null while keeping stderr for errors.
Also removed -t flag as TTY allocation is not needed in CI.
@jmgilman
jmgilman merged commit 76bc43f into master Dec 29, 2025
1 check passed
@jmgilman
jmgilman deleted the fix/suppress-imager-secrets branch December 29, 2025 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant