fix: build by pinning dependency - #132
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request unblocks the site container CI build by preventing npm i (without a lockfile in the Docker build context) from re-resolving sass to a newer release that requires a newer Node version than the build image provides.
Changes:
- Pin
sassto an exact version (1.58.3) insite/package.jsonto avoid accidental upgrades during container builds. - Align
site/package-lock.jsonto match the exactsassversion spec.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
site/package.json |
Pins sass to 1.58.3 to keep installs compatible with Node 18 in the container build. |
site/package-lock.json |
Updates the root dependency spec to match the pinned sass version. |
Files not reviewed (1)
- site/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🎉 This PR is included in version 2.21.0 🎉 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
De CI-build faalt sinds run 31676703291, in de site-containerbuild bij
RUN npm i:Waarom
site/.dockerignoresluit./package-lock.jsonuit, dus de lockfile komt de buildcontext niet binnen. In de container heeftnpm iniets om op te pinnen en herresolvet hij"sass": "^1.58.3"naar de nieuwste match — vandaag1.102.0, en die laat Node 18 vallen. De build-stage draait opnode:18.15.0-alpine.Dit staat los van de laatste feature-commit: die raakt twee
.vue-bestanden, eenlaunch.jsonen een.gitignore, geen dependencies. Het was gewoon de eerste build ná de sass-release die Node 18 laat vallen; dezelfde build faalt vandaag ook zónder die commit.Wat deze PR doet
sassexact vastzetten op1.58.3insite/package.json, en dezelfde spec bijwerken insite/package-lock.jsonzodat beide overeenkomen. Een exacte spec overleeft wél in de container, ook zonder lockfile.Nagekeken:
sass@1.58.3heeftengines: {node: ">=12.0.0"}— in orde op Node 18.sass@^1.58.3resolvet vandaag tot1.102.0.sass-loaderdeclareert sass nog, als peer^1.3.0; 1.58.3 voldoet, dus één kopie en geen geneste installatie.sass-loaderbinnen^13.2.0is 13.3.3 en peer't nog steedssass: ^1.3.0, dus de pin botst niet met een nieuwere loader.Wat dit níét oplost
Alle 129 directe dependencies van de site zweven (
^/~), geen enkele staat vast. Elke andere kan morgen op exact dezelfde manier de build breken, met een identiek foutbeeld.De structurele oplossing is de lockfile níét uitsluiten en
npm ivervangen doornpm ci, zodat imagebuilds reproduceerbaar zijn. Dat is bewust niet meegenomen hier — deze PR deblokkeert enkel de build.npm ciis strenger over overeenstemming tussenpackage.jsonen lockfile, dus dat verdient een eigen wijziging waarin dat eerst geverifieerd wordt.