Skip to content

[assistants] - fix: make assistant overrides optional - #87

Merged
JulesBelveze merged 1 commit into
mainfrom
fix/assistant-defaults
Jul 22, 2026
Merged

[assistants] - fix: make assistant overrides optional#87
JulesBelveze merged 1 commit into
mainfrom
fix/assistant-defaults

Conversation

@JulesBelveze

Copy link
Copy Markdown
Owner

Summary

  • allow assistants to use their default data configuration
  • preserve caller-provided override dictionaries
  • keep assistant names stable during configuration merging

Tests

  • uv run pre-commit run --files bert_squeeze/assistants/train_assistant.py bert_squeeze/assistants/distil_assistant.py tests/assistants/test_assistant_defaults.py
  • uv run pytest -q tests/assistants/test_assistant_defaults.py tests/assistants/test_train_assistant.py::TestTrainAssistant::test_custom_logger_kwargs tests/assistants/test_distil_assistant.py::TestDistilAssistant::test_custom_logger_kwargs tests/assistants/test_distil_assistant.py::TestDistilAssistant::test_torch_models

@JulesBelveze JulesBelveze changed the title fix: make assistant overrides optional [assistants] - fix: make assistant overrides optional Jul 22, 2026
@JulesBelveze
JulesBelveze merged commit 5d933e1 into main Jul 22, 2026
9 checks passed
@JulesBelveze
JulesBelveze deleted the fix/assistant-defaults branch July 22, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant