Feat/loom other camera livestream selector - #260
Merged
Conversation
Wires the previously-unused LivestreamSelector component into CameraConfigCard's sidebar for loom_camera modules, below the existing livestream, so an operator can flip through any other connected camera's feed without leaving the config page. Heading text is now configurable via a prop so this shared component can say "Other Camera" here instead of the generic "Livestream". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
LoomRecording.jsx uses the same .primary-button/.secondary-button classes as every other variant's recording page, but those are only defined in NewSessionForm.css, which loom never loads (it has its own standalone recording page instead of reusing basic's). Add a matching copy of the button rules so loom's buttons look the same as the rest. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.