Conversation
Defines v1.0 as safe-for-closed-LAN-use rather than fully hardened, scoping in the remaining diagnosed correctness bugs and the severity-regardless-of-network security items, and explicitly deferring the larger structural refactors and transport-layer hardening to post-1.0. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
progress() previously drew a whiptail --infobox per step throughout run_configuration()/run_clone_fix(). On terminals with smcup/rmcup support (virtually every SSH client), each infobox flashes onto the alternate screen and back off the instant it exits, since infoboxes don't wait for input. Between calls -- especially during multi-minute silent steps like npm install/apt-get install -- the primary screen just shows whatever was there before the flow started (blank, since configure_device() clears it beforehand), which reads as the whole TUI having vanished for the length of the run, over SSH specifically. It also meant apply_from_config() (the boot-time, fully headless path via saviour-provision.service) called whiptail with no controlling terminal at all, which fails immediately and, under run_configuration's set -e, would abort the entire boot-time provisioning run on the very first progress() call. progress() now just prints plain status lines -- unconditionally safe whether or not there's a tty, and nothing to flash since it never touches terminal modes. Also fixes a latent bug found while touching this: run_configuration() never called `set +e` at the end (unlike run_clone_fix(), which already does), so set -e -- a global shell option, not function-scoped -- stayed enabled for the rest of the script after a successful run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rogress Fix/saviour config tui progress
docs: add v1.0 milestone scope to CLAUDE.md
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.