Conversation
A module whose ZMQ hello/config reached the controller before its mDNS broadcast was ever seen got auto-registered by received_module_config() with ip="". module_discovery()'s early-return for already-known module IDs (added 2026-08-10 to stop spurious mDNS re-announcements from clobbering RECORDING status) then discarded every subsequent real mDNS announcement's ip/port/zeroconf_name too, since module_ip_changed() - the only other writer of .ip - is never actually called anywhere. The module stayed online (heartbeats kept flowing) but with a permanently blank IP, breaking the frontend's livestream URL. module_discovery() now refreshes ip/port/zeroconf_name in place when they differ from the tracked value, while leaving status/config/ last_heartbeat_time untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…hed-on-mdns-reannounce fix(modules): refresh module ip/port/zeroconf_name on mDNS re-announce
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.