Skip to content

809 metadata addition dates field - #822

Open
alisony755 wants to merge 12 commits into
mainfrom
809-metadata-addition-dates-field
Open

809 metadata addition dates field#822
alisony755 wants to merge 12 commits into
mainfrom
809-metadata-addition-dates-field

Conversation

@alisony755

Copy link
Copy Markdown
Collaborator
  • Added key dates field to metadata display and editing

@alisony755 alisony755 linked an issue Jul 23, 2026 that may be closed by this pull request
@netlify

netlify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploy Preview for dailp ready!

Name Link
🔨 Latest commit 937cd05
🔍 Latest deploy log https://app.netlify.com/projects/dailp/deploys/6a879bf3b49b3200088cc60a
😎 Deploy Preview https://deploy-preview-822--dailp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@alisony755
alisony755 force-pushed the 809-metadata-addition-dates-field branch 2 times, most recently from 03d2efc to 141179a Compare July 24, 2026 19:32
@@ -0,0 +1,3 @@
-- Insert the new set of key date IDs
insert into document_key_date (document_id, key_date_id)
select $1, unnest($2::uuid[]); No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what you are trying to accomplish with this line?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line inserts a row into document_key_date for each key date ID, associating all of those key dates with the document when updating metadata

"Dubai, UAE",
]

const approvedKeyDates = ["February 12, 1964"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this date is hard-coded?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting an error if I left it as const approvedKeyDates = ["February 12, 1964"], but I could change it to const approvedKeyDates: string[] = []

@GracefulLemming GracefulLemming left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alison, I think this looks good overall but I have one SQL and one web question for you to answer before approval.

alisony755 and others added 3 commits August 20, 2026 20:28
Merge branch '809-metadata-addition-dates-field' of github.com:NEU-DSG/dailp-encoding into 809-metadata-addition-dates-field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata Addition "Dates" field

2 participants