Fix: docs/VIDEO_MODEL.md - #130
Conversation
|
Hi Olek, thanks for your contribution! These are all valid changes and I was about to publish a similar fix but got stuck on a separate blocker. Due to some hiccup, the latest huggingface dataset release (version 26.04), which Alpasim uses by default, does not contain the GT camera frames needed to "seed" OmniDreams. They are available in the older 26.02 release but not in the current defaukl. We hope to get 26.04 fixed up with the missing files in the next couple of days and I prefer that over changing the data source for OmniDreams specifically. Which |
|
(closes: #119) |
|
Hi Michał, Thanks for getting back to me. I also encountered the dataset mismatch issue on my end, but as you noted, it's independent of what this PR addresses. Changes in this PR address issues in docs w.r.t. Docker build tags and cache directory fix, and doesn't propose changing the default OmniDreams data source. That said, let me elaborate on the Dataset mismatchThe deployment command from the doesn't specify a scenario artifact so it defaults to So for my experiments I refered to the dataset of version 26.01 and specifically used those Suggested fix: To avoid similar problems in the future, and improve experiment reproduciability, I would suggest allowing users to pin a dataset version in Tweaks to the flashdreams-alpasim DockerfileProblem Lastly, I noticed that docker/Dockerfile.alpasim in the flashdreams repository needs a slight modification to work with AlpaSim's managed_flashdreams deployment out of the box. The Dockerfile currently uses a two stage build: ARG FLASHDREAMS_BASE_IMAGE=flashdreams:local
FROM ${FLASHDREAMS_BASE_IMAGE} AS wheel-builder
...
FROM ${FLASHDREAMS_BASE_IMAGE}
COPY --from=wheel-builder /opt/flashdreams /opt/flashdreams
ENV VIRTUAL_ENV=/opt/flashdreams
ENV PATH="${VIRTUAL_ENV}/bin:${PATH}"
WORKDIR /appHowever, when running the Because not all project files (like pyproject.toml) are copied over from wheel-builder, the startup command My fix My current dirty workround is to simply remove multi-stage build steps starting from line 29 to the end. Once removed and rebuilt, I believe this issue belongs in the flashdreams repo, if you can confirm this behavior on your end, I’d be happy to open a PR over there with the cleaner fix. Sorry for the lengthy reply, but I hope my investigation helps shed some light on the onboarding setup from a new user's perspective. I'd be happy to contribute fixes for these as well :) Olek |
Hi,
I am proposing two minor fixes to the docs/VIDEO_MODEL.md on onboarding new users to video (world) models.
1. Flashdreams local image tag mismatch
Problem:
The current documentation instructs users to build the base image using the tag
flashdreams-base:local:docker build -t flashdreams-base:local -f docker/Dockerfile .However,
docker/Dockerfile.alpasimexpectsflashdreams:localas its base image. This causes the subsequent build command to fail because the expected base tag is missing:docker build -t flashdreams-alpasim:local -f docker/Dockerfile.alpasim .Fix:
I updated the documentation command to tag the base image as
flashdreams:local:docker build -t flashdreams:local -f docker/Dockerfile .2. Ensure cache directories existing on host
Problem:
Managed flashdreams container mounts cache directories in the
docker-compose.ymldeployment like:However if they don't exist on host, they might not be created by Docker automatically and crash the deployment.
Fix:
Added an explicit
mkdir -pstep to ensure the host cache directories exist prior to running the AlpaSim wizard: