docs: build the FlashDreams base under the tag Dockerfile.alpasim expects - #147
Open
amtellezfernandez wants to merge 1 commit into
Open
docs: build the FlashDreams base under the tag Dockerfile.alpasim expects#147amtellezfernandez wants to merge 1 commit into
amtellezfernandez wants to merge 1 commit into
Conversation
…ects Step 1 of the FlashDreams build instructions tags the base image flashdreams-base:local, but docker/Dockerfile.alpasim in FlashDreams declares ARG FLASHDREAMS_BASE_IMAGE=flashdreams:local, so following the steps verbatim fails at step 2 with a nonexistent-image error. FlashDreams' own docker/README.md builds under flashdreams:local and the ARG default has never had another value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
One of the developers for that project gave me an update. I'll try to merge it this week and ask you to try it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the FlashDreams build steps in
docs/VIDEO_MODEL.mdverbatim fails at step 2. Step 1 tags the base imageflashdreams-base:local, but FlashDreams'docker/Dockerfile.alpasimdeclaresARG FLASHDREAMS_BASE_IMAGE=flashdreams:local, so the second build stops with a nonexistent-image error.FlashDreams' own
docker/README.mdbuilds underflashdreams:local, and that ARG default has never had another value in its history, so aligning the tag here is what makes the two documents agree.If you already built the base under the old tag,
--build-arg FLASHDREAMS_BASE_IMAGE=flashdreams-base:localon step 2 works without rebuilding.Hit this while setting up the video-model renderer; checked against FlashDreams
main(4f776ab).