Update scenarios to current versions and fix scenario bugs - #5
Open
NullVoxPopuli-ai-agent wants to merge 1 commit into
Open
Conversation
- The app-auto-import-* apps were generated with --embroider, so both
app flavors were running identical embroider webpack builds and the
ember-auto-import (classic) pipeline was never actually tested. The
app-auto-import-* apps now use a classic app.toTree() build.
- Bump @embroider/compat to ^3.9.4, @embroider/core to ^3.5.10, and
@embroider/webpack to ^4.1.2 (the versions released from embroider's
stable branch, which is the webpack line). The old ^3.4.3 compat
pins now resolve @embroider/compat 4.x from main, whose compatBuild
has the vite-era signature and fails with 'Class constructor Webpack
cannot be invoked without new'.
- Add ember-source as a devDependency of the libs; current
babel-plugin-ember-template-compilation needs it resolvable for
template compilation at addon build time.
- Fix the-test.js in both import-sync apps: lib-import-sync only has a
default export, so 'import { theFn }' was always undefined. Also,
dependencySatisfies('@embroider/core', '*') checks the addon's own
dependencies (which don't include @embroider/core), so the correct
expectation is 'expecting broccoli' in both build systems.
With these fixes plus embroider-build/ember-auto-import#718 and
embroider-build/embroider#2780 linked in, all 8 scenario apps pass.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the quest repro (embroider-build/embroider#1773) so it tests what it says it tests:
app-auto-import-*apps were generated with--embroider, so both app flavors ran identical embroider webpack builds — the classic ember-auto-import pipeline was never actually exercised. They now use a classicapp.toTree()build.@embroider/compat→^3.9.4,@embroider/core→^3.5.10,@embroider/webpack→^4.1.2(the stable-branch webpack line). The old^3.4.3pins now resolve@embroider/compat@4.xfrom main, whosecompatBuildhas the vite-era signature and fails withClass constructor Webpack cannot be invoked without 'new'.ember-sourceas a devDependency of the libs (currentbabel-plugin-ember-template-compilationneeds it resolvable at addon build time).the-test.jsin both import-sync apps: the lib only has a default export, soimport { theFn }was always undefined; anddependencySatisfies('@embroider/core', '*')checks the addon's own dependencies, so'expecting broccoli'is the correct expectation in both build systems.Current matrix on published packages:
no-depspasses everywhere;template-only,glimmer-component, andimport-syncfail under ember-auto-import;import-syncfails under embroider 3. All 8 apps pass with embroider-build/ember-auto-import#718 and embroider-build/embroider#2780 linked in.🤖 Generated with Claude Code