[19.0][FIX] mail_activity_team: fix team functionality and related views for mail activities - #200
[19.0][FIX] mail_activity_team: fix team functionality and related views for mail activities#200CRogos wants to merge 1 commit into
Conversation
95158b5 to
ffaa8b2
Compare
|
Add port forward of #148 |
c7d286a to
21ce019
Compare
21ce019 to
d3380ce
Compare
d3380ce to
682e486
Compare
|
@StefanRijnhart could you review/merge? |
|
Is this a migration fix now or a forward port? There is only one commit. |
|
There were some bugs in the migration and the one PR was missing... I probably squashed everything. |
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Please create separate PRs for the fix and the backport
|
It is not a backport. It is both code which was missed out from the migration. I don't see any benefit to move this into two separate PRs. (I do not have the time, so I won't be able to do that.) |
|
This is just a forward, right? Can you update the description of the PR? |
| def _to_store_defaults(self, target): | ||
| values = super()._to_store_defaults(target) | ||
| values.append(Store.One("team_id", "name")) | ||
| return values |
There was a problem hiding this comment.
Most of the stuff this is a port forward. But I think there are some overlapping changes with #216. Maybe we could merge the other PR first, than I'll rebase and cleanup this PR to only contain the port of #148 .
As you already mentioned in the other PR, the module is currently not working and therefore a base + port is also not working.
5 participants
@muaazsiddiq @MohamedOsman7 we did a bad job on the migration. Could you review again?
When opening a page with activities this error occurs:
Further more, the marked fields were not displayed.
