Skip to content

[16.0][IMP] account_invoice_margin: set new option 'optional' hide to margin fields on tree views. - #267

Merged
OCA-git-bot merged 4 commits into
OCA:16.0from
grap:16.0-IMP-account_invoice_margin-optional-margin-fields-SLG
Aug 4, 2026
Merged

[16.0][IMP] account_invoice_margin: set new option 'optional' hide to margin fields on tree views.#267
OCA-git-bot merged 4 commits into
OCA:16.0from
grap:16.0-IMP-account_invoice_margin-optional-margin-fields-SLG

Conversation

@legalsylvain

@legalsylvain legalsylvain commented May 18, 2026

Copy link
Copy Markdown
Contributor

Rational:

  • the margin fields are usefull to be in the tree. However, it is not usefull for all user in a day to day basis. put optional='hide' to make the invoice and invoice lines list tree view lighter.

  • prevent to display useless fields on account.move.lines (when not related to out invoices)

  • do not display margin in move tree views, if there are not out invoices

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @sergio-teruel,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:account_invoice_margin Module account_invoice_margin series:16.0 labels May 18, 2026
@pedrobaeza pedrobaeza changed the title [IMP] account_invoice_margin: set new option 'optional' hide to margin fields on tree views. [16.0][IMP] account_invoice_margin: set new option 'optional' hide to margin fields on tree views. May 19, 2026
@pedrobaeza pedrobaeza added this to the 16.0 milestone May 19, 2026
@legalsylvain
legalsylvain force-pushed the 16.0-IMP-account_invoice_margin-optional-margin-fields-SLG branch from 5b28936 to 8fe4515 Compare July 7, 2026 14:49
@legalsylvain

Copy link
Copy Markdown
Contributor Author

@@sergio-teruel could you take a look on this one ?

thanks !

@sergio-teruel sergio-teruel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds perfect to me

@legalsylvain

Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain

Copy link
Copy Markdown
Contributor Author

@sergio-teruel could you merge this one ?

thanks !

@sergio-teruel

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-267-by-sergio-teruel-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@sergio-teruel The merge process could not be finalized, because command twine check odoo_addon_account_invoice_margin-16.0.1.0.1.6-py3-none-any.whl failed with output:

Checking odoo_addon_account_invoice_margin-16.0.1.0.1.6-py3-none-any.whl: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 37: Warning: Cannot scale image!                                  
           Could not get size from                                              
         "https://raw.githubusercontent.com/OCA/margin-analysis/16.0/account_inv
         oice_margin/static/description/account_invoice_form.png":              
           Requires Python Imaging Library.                                     
           Reading external files disabled.                                     
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.   

…n fields on tree views.

Rational: this field is usefull to be in the tree. However, it is not usefull for all user in a day to day basis.
put optional='hide' to make the invoice and invoice lines list tree view lighter.
…ccount.move.lines (when not related to out invoices)
@legalsylvain
legalsylvain force-pushed the 16.0-IMP-account_invoice_margin-optional-margin-fields-SLG branch from 2375bf3 to 1aa0837 Compare August 4, 2026 12:14
@legalsylvain

Copy link
Copy Markdown
Contributor Author

Weird error ... nothing to do with the current PR.

@sergio-teruel : I tried to fix the problem in 1aa0837

could you rerun the merge process ?

thanks !

@sergio-teruel

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-267-by-sergio-teruel-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit c63f33c into OCA:16.0 Aug 4, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 3035394. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants