Skip to content

[19.0][ADD] product_pricelist_item_uom_standard - #2364

Open
Ricardoalso wants to merge 1 commit into
OCA:19.0from
camptocamp:product_pricelist_item_uom_standard
Open

[19.0][ADD] product_pricelist_item_uom_standard#2364
Ricardoalso wants to merge 1 commit into
OCA:19.0from
camptocamp:product_pricelist_item_uom_standard

Conversation

@Ricardoalso

Copy link
Copy Markdown

Add a backport of Odoo 19.3's native pricelist-rule-by-UoM feature (odoo/odoo@d2648b1d9839), restricting pricelist item rules to a specific product packaging.

OCA/product-attribute already ships product_pricelist_item_uom, but it defines uom_id on product.pricelist.item as a computed field always defaulted to the product's base UoM, and it never filters rule selection. The two modules are declared mutually exclusive via the manifest excludes key.

Add a backport of Odoo 19.3's native pricelist-rule-by-UoM
feature (odoo/odoo@d2648b1d9839), restricting pricelist item
rules to a specific product packaging.

OCA/product-attribute already ships product_pricelist_item_uom,
but it defines uom_id on product.pricelist.item as a computed
field always defaulted to the product's base UoM, and it never
filters rule selection. The two modules are declared mutually
exclusive via the manifest excludes key.

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm not sure we want to keep both product_pricelist_item_uom and this one.
I'd be more inclined to have this one replace the existing product_pricelist_item_uom, consuming its name, given it's essentially the same feature -- but this one is aligned to what's implemented in standard in 19.3 (and future 20.0)

ping @JordiBForgeFlow @rousseldenis @monen17

@monen17

monen17 commented Aug 5, 2026

Copy link
Copy Markdown

I'm not sure we want to keep both product_pricelist_item_uom and this one.

I agree it's better to avoid excludeing modules.

I'd be more inclined to have this one replace the existing product_pricelist_item_uom, consuming its name, given it's essentially the same feature -- but this one is aligned to what's implemented in standard in 19.3 (and future 20.0)

I'd rather go with the REF commit you suggested in #2308 (comment) so the commit history of product_pricelist_item_uom is preserved and we can see how its logic changes/gets migrated.

@Ricardoalso

Ricardoalso commented Aug 6, 2026

Copy link
Copy Markdown
Author

Thanks!

I'm not sure we want to keep both product_pricelist_item_uom and this one. I'd be more inclined to have this one replace the existing product_pricelist_item_uom, consuming its name, given it's essentially the same feature -- but this one is aligned to what's implemented in standard in 19.3 (and future 20.0)

ping @JordiBForgeFlow @rousseldenis @monen17

I'm not sure we want to keep both product_pricelist_item_uom and this one.

I agree it's better to avoid excludeing modules.

I'd be more inclined to have this one replace the existing product_pricelist_item_uom, consuming its name, given it's essentially the same feature -- but this one is aligned to what's implemented in standard in 19.3 (and future 20.0)

I'd rather go with the REF commit you suggested in #2308 (comment) so the commit history of product_pricelist_item_uom is preserved and we can see how its logic changes/gets migrated.

Thanks for the follow-up on this! I like the option of pushing a REF commit ([REF] product_pricelist_item_uom: backport from odoo 19.3) on top of product_pricelist_item_uom, as it would indeed preserve the commit history.

I will rebase my work on ForgeFlow:19.0-mig-product_pricelist_item_uom and rework this PR if there is consensus among the contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants