ci: add a non-blocking JDK 28 early-access preview canary job - #1901
Closed
velo wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one CI job. No source changes, Java 17 baseline untouched.
JEP 401 (Value Objects) is a preview feature in JDK 28. With
--enable-previewthe primitive wrappers and
LocalDatebecome value classes, so==andidentityHashCodeturn state-based for them. Querydsl keysSerializerBase.constantToLabeland the alias proxy cache by identity on valuessupplied by the caller, so that change lands on us before it lands on anything
we control. Better to see it in CI than in an issue report.
The job runs the
no-databasessuite on a JDK 28 EA build with preview enabledat runtime, using
-Dtoolchain.skip=truethe same way the existingwindowsjobdoes.
It cannot block anything. It is marked
continue-on-errorand isdeliberately left out of the aggregate
buildcheck'sneedslist, so a brokenEA build, a withdrawn EA release, or a real preview regression all fail quietly.
Caveat worth stating plainly
I could not verify this locally — JDK 28 EA downloads are unreachable from my
environment, so this job's first real run is the one on this PR. Two things I
was not able to confirm in advance:
actions/setup-javaresolves28-eafor thetemurindistribution==behaviour withonly runtime
--enable-preview, given our classes are compiled without previewIf the job goes green and nothing changes, that is a useful result too: it means
the migration is not yet observable and the canary is in place for when it is.
Happy to drop or rework this if the first run shows the setup is wrong.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WnNBe1GoG2SxfU3FN7bcAA