Fixed the race condition: removed premature runHotkeyReaderThread() call before watchFiles() - #2073
Open
sajeerzeji wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2070
PR Ci.Common: OpenLiberty/ci.common#526
PR Ci.Gradle: OpenLiberty/ci.gradle#1095
As a part of this PR OpenLiberty/ci.common#526 we mad ci.common print the "Liberty is running in dev mode." startup banner from inside watchFiles() after all directories are registered with the WatchService, the explicit util.runHotkeyReaderThread(executor) call that DevMojo.doDevMode() made between startServer() and watchFiles() is no longer needed and has been removed. That call was the source of the race condition described in the issue, it caused the ready message to fire before the WatchService had registered any source directories, making it an unreliable signal for tests and users. The early hotkey reader thread is still started via startEarlyHotkeyReader() before server startup to allow quitting during startup, and the post-test-run re-print from the finally block inside the watch loop remains unchanged.