test(conn): model receiving player in deleteStream setup-timeout test - #208
Merged
Merged
Conversation
Unpaused players with zero outbound relay are reaped after the setup grace window (PR #207). The deleteStream regression test must set media_bytes_sent so it exercises a legitimate viewer, not a squatter. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
AlexanderWagnerDev
marked this pull request as ready for review
August 10, 2026 09:58
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI on PR #207 (
delete_stream_clears_is_playing_and_grants_a_fresh_window).PR #207 reaps unpaused play sessions with zero outbound relay after the setup grace window. The existing
deleteStreamregression test modeled a player without any relay bytes, sosession_setup_timed_out()correctly reaped it and the assertion failed.Change
Set
media_bytes_sent = 1in the test so it exercises a legitimate viewer receiving relay, not an idle squatter.CI
After merge, PR #207 should rebase on
mainto pick up this test fix.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.