regen/embed.pl: Hide most KEY_foo symbols from XS#24602
Open
khwilliamson wants to merge 1 commit into
Open
Conversation
There are a lot of symbols in keywords.h that are visible to all XS
code. Most code has no business knowing about these.
I've tried removing them all before, but that causes cpan failures.
Now, I have grepped metacpan for these, and only a few are actually
used. They fall into two classes
1) 'my' and 'our'
2) and a couple like KEY_BEGIN
So I'm trying again, early in the development cycle, leaving just 'my',
'our', and all the ones that are like KEY_BEGIN
Contributor
|
This makes me wonder what the criterion should be for making such a key public or not, this feels a bit random. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of symbols in keywords.h that are visible to all XS code. Most code has no business knowing about these.
I've tried removing them all before, but that causes cpan failures.
Now, I have grepped metacpan for these, and only a few are actually used. They fall into two classes
1) 'my' and 'our'
2) and a couple like KEY_BEGIN
So I'm trying again, early in the development cycle, leaving just 'my', 'our', and all the ones that are like KEY_BEGIN