Skip to content

feat(sandboxes): add typed image listing - #855

Merged
akirillo merged 3 commits into
mainfrom
feature/sdk-platform-image-listing
Aug 19, 2026
Merged

feat(sandboxes): add typed image listing#855
akirillo merged 3 commits into
mainfrom
feature/sdk-platform-image-listing

Conversation

@akirillo

@akirillo akirillo commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The VM sandbox load-test bootstrap and the Prime CLI need one typed path for image discovery. Previously, the lightweight SDK did not expose GET /images, and prime images list duplicated the endpoint's query and response handling with untyped dictionaries.

This change adds synchronous and asynchronous SDK listing with typed artifact rows, pagination, build status, artifact type, owner type, and existing visibility values. The models mirror the platform FastAPI ImageResponse and GenericPaginationResponse schemas. They preserve camel-case API aliases while accepting the backend's current snake-case pagination key and legacy responses that omit the total count. Listing follows configured team context, supports platform scope, validates pagination, and rejects conflicting platform and team scopes.

prime images list now delegates request construction and parsing to ImageClient.list, renders directly from the typed models, and emits camel-case JSON. The CLI dependency floor is prime-sandboxes>=0.2.39, the planned release containing this API. No package version changes are included.

Test: Ruff and type checks pass. All 87 focused SDK and CLI image-list tests pass. The 197 hermetic sandbox SDK tests also pass. Live sync, async, and CLI personal listings parsed successfully; the supplied non-admin key received 403 Admin role required for platform scope, so a successful platform response remains unverified.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c336f2f490

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/prime-sandboxes/src/prime_sandboxes/models.py Outdated
@akirillo
akirillo merged commit 47436b8 into main Aug 19, 2026
17 checks passed
@akirillo
akirillo deleted the feature/sdk-platform-image-listing branch August 19, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants