feat(sandboxes): add typed image listing - #855
Merged
Merged
Conversation
akirillo
requested review from
DamianB-BitFlipper,
JannikSt,
JohannesHa,
burnpiro,
kcoopermiller,
kennethnym and
willccbb
as code owners
August 19, 2026 20:14
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c336f2f490
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DamianB-BitFlipper
previously approved these changes
Aug 19, 2026
DamianB-BitFlipper
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VM sandbox load-test bootstrap and the Prime CLI need one typed path for image discovery. Previously, the lightweight SDK did not expose
GET /images, andprime images listduplicated the endpoint's query and response handling with untyped dictionaries.This change adds synchronous and asynchronous SDK listing with typed artifact rows, pagination, build status, artifact type, owner type, and existing visibility values. The models mirror the platform FastAPI
ImageResponseandGenericPaginationResponseschemas. They preserve camel-case API aliases while accepting the backend's current snake-case pagination key and legacy responses that omit the total count. Listing follows configured team context, supports platform scope, validates pagination, and rejects conflicting platform and team scopes.prime images listnow delegates request construction and parsing toImageClient.list, renders directly from the typed models, and emits camel-case JSON. The CLI dependency floor isprime-sandboxes>=0.2.39, the planned release containing this API. No package version changes are included.Test: Ruff and type checks pass. All 87 focused SDK and CLI image-list tests pass. The 197 hermetic sandbox SDK tests also pass. Live sync, async, and CLI personal listings parsed successfully; the supplied non-admin key received
403 Admin role requiredfor platform scope, so a successful platform response remains unverified.