Fix performance on locked "Head- Tail lights" by removing unnecessary state updates - #14
Open
notstevy wants to merge 1 commit into
Open
Conversation
When these lights were in the locked mode, they were updated when the driving direction did not match their configured value and immediately updated back to the old value (since they were locked). This behavior caused lag spikes because Create had to update the train twice for each misconfigured light, even though updates were unwanted. Now, the light mode checks are only run in the unlocked mode, which improves performance immensely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When these lights were in the locked mode, they were updated when the driving direction did not match their configured value and immediately updated back to the old value (since they were locked).
This behavior caused lag spikes because Create had to update the train twice for each misconfigured light, even though updates were unwanted.
Now, the light mode checks are only run in the unlocked mode, which improves performance immensely.
This fixes the issue #13