fix: balance EventLanding hero on wide screens - #751
Conversation
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Anshumancanrock The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe event hero now separates description and links from event metadata. The metadata appears in an accessible details card. CSS adds a two-column layout, sticky details, updated spacing, and responsive single-column behavior. ChangesEvent hero layout
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @fishman, could you please take a look at this PR when you have time? Thanks! |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Event landing pages capped the description at 720px, so wide screens had a big empty gap on the right. Moved date/location/time into a side card next to the description so the layout fills naturally.
Which issue(s) this PR fixes:
Fixes #749
Before:
Description stuck at 720px max-width, empty space on the right on widescreen.
After:
Description + links on the left, event details card (date / location / time / room) on the right; stacks on smaller screens.
Checklist:
npm run lintandnpm run format:checkpassnpm run buildsucceeds for bothenandzhgit commit -s)Summary by CodeRabbit