Fix ABI record lookup for qualified paths - #29622
Open
1sgtpepper wants to merge 10 commits into
Open
Conversation
1sgtpepper
force-pushed
the
fix/29615-abi-record-location
branch
2 times, most recently
from
August 6, 2026 14:05
678f836 to
05eaca0
Compare
1sgtpepper
force-pushed
the
fix/29615-abi-record-location
branch
from
August 6, 2026 16:05
caf5e18 to
4cf276a
Compare
1sgtpepper
marked this pull request as ready for review
August 7, 2026 09:25
| let found = match stub { | ||
| ast::Stub::FromAleo { program, .. } => { | ||
| program.composites.iter().find(|(sym, _)| *sym == name).map(|(_, c)| c.is_record) | ||
| match stubs.get(&location.program)? { |
Collaborator
There was a problem hiding this comment.
When ABI generation processes a FromLeo dependency, this map is the dependency nested Program.stubs, so sibling dependencies are absent and valid external records can be emitted as Plaintext::Struct. Please thread the outer reachable stub map into dependency and external-interface ABI conversion, and add a three-program regression test that asserts Record in both generated ABIs.
mohammadfawaz
added
馃悰 bug
1sgtpepper
marked this pull request as draft
August 20, 2026 07:29
1sgtpepper
marked this pull request as ready for review
August 21, 2026 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ABI generation classified composites by terminal name, so a module struct could be mistaken for a same-named record. Resolve composites by their complete
(program, path)identity, including direct interface record prototypes.Fixes #29615.
Compatibility
Leo source syntax and the ABI schema are unchanged. The fix changes only the
RecordversusStructclassification for qualified composites, including program and interface ABI output. Concrete lookup covers the current program, imported Leo programs, Aleo stubs, and libraries. Interface ABI conversion classifies direct record prototypes only; it does not add parent-interface record prototypes to a child interface, and inherited interface member behavior is unchanged.Test Plan
Record/Structclassification in both program and interface ABI output.cargo +nightly fmt --all -- --checkgit diff --checkbash -n tests/tests/cli/test_abi_record_identity/COMMANDScode-quality,leo-executable,test-linux,test-macos,test-windows.Related PRs
#29623 fixes the related dynamic-interface location bug independently; this PR targets
masterand does not depend on it.