Skip to content

Release Toggle Track Pitch Envelope v1.0 - #1611

Merged
cfillion merged 3 commits into
ReaTeam:masterfrom
grayson-solis:reapack.com_upload-1751601972537
Jul 8, 2025
Merged

Release Toggle Track Pitch Envelope v1.0#1611
cfillion merged 3 commits into
ReaTeam:masterfrom
grayson-solis:reapack.com_upload-1751601972537

Conversation

@grayson-solis

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Envelopes/Takes/graysonsolis_Toggle Track Pitch Envelope.lua Outdated

chunk = chunk
:gsub("ACT %d+", "ACT " .. (show and 1 or 0))
:gsub("VIS %d+ %d+ %d+", "VIS " .. (show and "1 1 1" or "0 0 0"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from the previous PR still apply: https://github.com/ReaTeam/ReaScripts/pull/1571/files#r2083305666

(This is not a packaging problem though so won't block a release here. Just a heads up for likely bugs.)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling that setting is the only way I got it to work. might be another way but it has worked fine for me for the last month or 2 ive been using it hours daily

@cfillion
cfillion merged commit 75f960c into ReaTeam:master Jul 8, 2025
1 check passed

local track = reaper.GetSelectedTrack(0, 0)
if not track then
reaper.PreventUIRefresh(0)

@cfillion cfillion Jul 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, while this line here (and same a bit below) is correctly undoing the PreventUIRefresh from above, it forgets to the the same for Undo_BeginBlock.

An easy solution would be to wait until later before enabling PreventUIRefresh and Undo_BeginBlock. 😉

Thankfully REAPER has a fail-safe against scripts doing this kind of mistake so there are no ill effects.

@Buy-One Buy-One Jul 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schwa suggests here https://forum.cockos.com/showpost.php?p=2297817&postcount=2

You should always call PreventUIRefresh(1) to initiate and PreventUIRefresh(-1) to end

Is 0 a valid argument as well?

@cfillion cfillion Jul 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, nope it is not. (Well, not "invalid" per se, but adding 0 just does nothing.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants