Skip to content

Run E2E app and store cleanup in parallel #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isaacroldan wants to merge 1 commit into from
Closed

Run E2E app and store cleanup in parallel #8295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions .github/workflows/tests-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,12 +276,16 @@ jobs:
retention-days: 14

e2e-cleanup:
name: 'Cleanup current-run E2E resources'
name: 'Cleanup current-run E2E ${{ matrix.resource }}'
needs: e2e-tests
if: ${{ always() && needs.e2e-tests.result != 'skipped' }}
runs-on: ubuntu-latest
timeout-minutes: 20
continue-on-error: true
strategy:
fail-fast: false
matrix:
resource: [ 'apps', 'stores' ]
steps:
- uses: actions/checkout@v6
with:
Expand All @@ -305,18 +309,7 @@ jobs:
E2E_ORG_ID: ${{ secrets.E2E_ORG_ID }}
E2E_LOADTEST_HEADER: ${{ secrets.E2E_LOADTEST_HEADER }}
run: pnpm --filter e2e exec tsx scripts/prime-browser-auth.ts
- name: Cleanup current-run E2E apps
if: ${{ always() }}
continue-on-error: true
env:
E2E_ACCOUNT_EMAIL: ${{ secrets.E2E_ACCOUNT_EMAIL }}
E2E_ACCOUNT_PASSWORD: ${{ secrets.E2E_ACCOUNT_PASSWORD }}
E2E_ORG_ID: ${{ secrets.E2E_ORG_ID }}
E2E_LOADTEST_HEADER: ${{ secrets.E2E_LOADTEST_HEADER }}
run: |
RUN_TOKEN=$(node -e "process.stdout.write(BigInt(process.env.GITHUB_RUN_ID).toString(36))")
pnpm --filter e2e exec tsx scripts/cleanup-apps.ts --pattern "r${RUN_TOKEN}"
- name: Cleanup current-run E2E stores
- name: Cleanup current-run E2E ${{ matrix.resource }}
if: ${{ always() }}
continue-on-error: true
env:
Expand All @@ -326,7 +319,7 @@ jobs:
E2E_LOADTEST_HEADER: ${{ secrets.E2E_LOADTEST_HEADER }}
run: |
RUN_TOKEN=$(node -e "process.stdout.write(BigInt(process.env.GITHUB_RUN_ID).toString(36))")
pnpm --filter e2e exec tsx scripts/cleanup-stores.ts --pattern "r${RUN_TOKEN}"
pnpm --filter e2e exec tsx scripts/cleanup-${{ matrix.resource }}.ts --pattern "r${RUN_TOKEN}"

type-diff:
if: github.event.pull_request.head.repo.full_name == github.repository
Expand Down
Loading