Skip to content

Cover edge padding CLI aliases - #10

Merged
Spiffical merged 1 commit into
masterfrom
agent/cover-edge-padding-aliases
Jul 15, 2026
Merged

Cover edge padding CLI aliases#10
Spiffical merged 1 commit into
masterfrom
agent/cover-edge-padding-aliases

Conversation

@Spiffical

Copy link
Copy Markdown
Owner

What changed

  • rename the negative padding test to describe both edge-padding aliases
  • exercise --clip-pad-seconds and --edge-pad-seconds with and without event mode
  • give each parametrized mode a readable test ID

Why

The previous test name only mentioned clip padding and only covered the non-event path, making failures less informative and leaving event-mode behavior without direct regression coverage.

User impact

No runtime behavior changes. The expanded regression matrix protects clean argparse errors for both aliases in every relevant mode.

Validation

  • 7 passed in the focused CLI suite
  • 68 passed, 2 deselected in the full offline suite
  • git diff --check

@Spiffical
Spiffical marked this pull request as ready for review July 15, 2026 18:01
Copilot AI review requested due to automatic review settings July 15, 2026 18:01
@Spiffical
Spiffical merged commit e2ba621 into master Jul 15, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands regression coverage for the generate_spectrograms.py CLI to ensure both edge-padding aliases (--clip-pad-seconds and --edge-pad-seconds) produce clean argparse-style errors (no traceback) for negative values in both event and non-event modes.

Changes:

  • Renames the negative padding test to reflect both edge-padding aliases.
  • Adds event-mode and non-event-mode coverage for each alias via parametrization.
  • Improves parametrized-case readability by adding explicit test IDs for event-mode variants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants