Add tests and update licenses - #458
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe PR removes multiple LGPL-3.0 license files and adds Apache-2.0 license documents. LICENSE.md is revised to list updated license assignments and guidance. SPDX license identifiers (Apache-2.0) are added to many header and source files across Platforms, TactilityFreeRtos, and TactilityKernel. Two new unit test files are added: Tests/TactilityKernel/MutexTest.cpp and Tests/TactilityKernel/RecursiveMutexTest.cpp, exercising mutex and recursive-mutex behaviors including construction, locking, try-lock, and cross-task blocking. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
Documentation/ideas.md (1)
5-5: Clarify SPDX TODO to match the updated licensing plan.The TODO references both
GPL-3.0-onlyandApache-2.0. If GPL is no longer intended for code files after this update, consider rewording to avoid accidental mislabeling.✏️ Suggested wording
-- Add `// SPDX-License-Identifier: GPL-3.0-only` and `// SPDX-License-Identifier: Apache-2.0` to individual files in the project +- Add appropriate SPDX-License-Identifier headers per module license (e.g., Apache-2.0 for Platforms/* and TactilityKernel)
Replace LGPL from past commit with Apache License 2.0 for the newly created projects:
Add license headers to source code in:
Updated LICENSE.md
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.