test({react,preact}-query/useSuspenseQuery): assert the 'loading' fallback is rendered when gcTime is 0 by sukvvon · Pull Request #11076 · TanStack/query

sukvvon · 2026-07-18T05:10:55Z

🎯 Changes

Adds an assertion right after the initial render that the Suspense 'loading' fallback is shown before advancing timers, in should render the correct amount of times in Suspense mode when gcTime is set to 0 for both react-query and preact-query. The sibling test in the same file (should render the correct amount of times in Suspense mode, without gcTime: 0) already follows this convention; the gcTime: 0 variant was missing it.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Improved Suspense query coverage by asserting the loading fallback is shown immediately before advancing timers to let the query resolve when garbage-collection time is set to zero.

nx-cloud · 2026-07-18T05:11:26Z

View your CI Pipeline Execution ↗ for commit ea6aaa5

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 58s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	40s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-18 05:19:07 UTC

coderabbitai · 2026-07-18T05:11:56Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c8e841e1-74c8-45bb-babf-758d44e401db

📥 Commits

Reviewing files that changed from the base of the PR and between ea6aaa5 and 6af990f.

📒 Files selected for processing (2)

packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx
packages/react-query/src/__tests__/useSuspenseQuery.test.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

packages/preact-query/src/tests/useSuspenseQuery.test.tsx
packages/react-query/src/tests/useSuspenseQuery.test.tsx

📝 Walkthrough

Walkthrough

Suspense query tests for React and Preact now assert that the "loading" fallback appears immediately after rendering, before fake timers advance and the resolved output is checked.

Changes

Suspense fallback tests

Layer / File(s)	Summary
Validate initial Suspense fallback `packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx`, `packages/react-query/src/__tests__/useSuspenseQuery.test.tsx`	Adds assertions confirming the `"loading"` fallback renders before timers resolve the query and `"rendered"` is checked.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

TanStack/query#11036: Related Suspense behavior changes involving query resolution and setQueryData.
TanStack/query#11075: Related Suspense tests adding immediate loading-fallback assertions.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main test assertion change for react-query and preact-query when gcTime is 0.
Description check	✅ Passed	The description matches the required template and includes changes, checklist, and release impact sections with sufficient detail.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/suspense-query-gctime-zero-loading-fallback-assertion

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-18T05:11:58Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

…lback is rendered when gcTime is 0

pkg-pr-new · 2026-07-18T05:16:41Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11076

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11076

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11076

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11076

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11076

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11076

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11076

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11076

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11076

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11076

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11076

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11076

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11076

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11076

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11076

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11076

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11076

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11076

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11076

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11076

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11076

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11076

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11076

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11076

commit: 6af990f

github-actions · 2026-07-18T05:17:34Z

size-limit report 📦

Path	Size
react full	12.13 KB (0%)
react minimal	9.08 KB (0%)

sukvvon changed the title ~~test(react-query,preact-query/useSuspenseQuery): assert the 'loading' fallback is rendered when gcTime is 0~~ test({react,preact}-query/useSuspenseQuery): assert the 'loading' fallback is rendered when gcTime is 0 Jul 18, 2026

test({react,preact}-query/useSuspenseQuery): assert the 'loading' fal…

6af990f

…lback is rendered when gcTime is 0

sukvvon force-pushed the test/suspense-query-gctime-zero-loading-fallback-assertion branch from ea6aaa5 to 6af990f Compare July 18, 2026 05:12

sukvvon self-assigned this Jul 18, 2026

coderabbitai Bot mentioned this pull request Jul 18, 2026

test({react,preact}-query/usePrefetchQuery): assert the 'Loading...' fallback is rendered before the prefetch resolves #11075

Merged

4 tasks

sukvvon merged commit b955f60 into main Jul 18, 2026
9 checks passed

sukvvon deleted the test/suspense-query-gctime-zero-loading-fallback-assertion branch July 18, 2026 05:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test({react,preact}-query/useSuspenseQuery): assert the 'loading' fallback is rendered when gcTime is 0#11076

test({react,preact}-query/useSuspenseQuery): assert the 'loading' fallback is rendered when gcTime is 0#11076
sukvvon merged 1 commit into
mainfrom
test/suspense-query-gctime-zero-loading-fallback-assertion

sukvvon commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

pkg-pr-new Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Jul 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 18, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Jul 18, 2026 •

edited

Loading

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading