Avoid building an ISL AST for illegal schedules - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion Python changes: TiraLib PR #59.
The server used to call
gen_time_space_domain()andgen_isl_ast()even after the schedule had failed legality checks. For some invalid transformed domains, that AST construction can take hours or use excessive memory.The server now builds and returns an ISL AST only when the final legality result is
true. Legal schedules are unchanged. Illegal schedules return their verdict with an empty AST.The shared computation-list parser now also removes duplicate computation pointers while preserving their first occurrence. This prevents repeated names in a schedule string from applying actions such as tiling more than once.
Tests cover empty ASTs for illegal schedules and verify that repeated tiling targets are equivalent to a single target. The TiraLibCpp suite passes all 23 tests.