Update all notebooks to be rendered - #34
Conversation
Neonbluestoplight
left a comment
Neonbluestoplight
left a comment
There was a problem hiding this comment.
These are mostly nitpicks and tiny enhancements rather than big fixes. I have checked for typos, whether the dataset links work or not and general rendering.
All looks good to me but would like to hear what you say and if anything would require changing
There was a problem hiding this comment.
Minor nitpick not really an issue. Maybe could add titles to differentiate plots (This is just shows as an example but is a case for all the plots shown).
There was a problem hiding this comment.
Missing attribution on datasets when compared to other notebooks
There was a problem hiding this comment.
Overall suggestions
These are more or less nitpicks rather than things that need to be done:
No data attribution when compared to other notebooks (as in crediting the providers). May be unnecessary since link to Zenodo covers it.
Not sure what this means:
Here demo how to read in Nikon Data, perform FDK reconstruction, and perform model based image reconstruction utilizing a primal dual hybrid gradient.
Maybe "Demo on how to...."
Maybe add code blocks to show2D since it has been done with all the other methods.
There was a problem hiding this comment.
flat instead of fla
The [Data set] part seems to be for a link which is not present (maybe it is just the Zenodo link?)
Should be a code block (Text block after cell 13)
There was a problem hiding this comment.
- Maybe unnecessary but CIL version used for development of notebook not mentioned:
2 identical plots with no indication about a need?
| conda env create -f https://tomographicimaging.github.io/scripts/env/cil_demos.yml | ||
| ``` | ||
|
|
||
| Please note, although many were developed with earlier versions of CIL, all notebooks have been tested with CIL v26.0.0 |
There was a problem hiding this comment.
| Please note, although many were developed with earlier versions of CIL, all notebooks have been tested with CIL v26.0.0 | |
| > [!NOTE] | |
| > Although many were developed with earlier versions of CIL, all notebooks have been tested with CIL v26.0.0 |
Will render as below
Note
Although many were developed with earlier versions of CIL, all notebooks have been tested with CIL v26.0.0
2 participants
Contribution Overview
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.