Skip to content

Require explicit content_type in test helpers #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Aug 6, 2026
+63 −13
Merged

Require explicit content_type in test helpers #3329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 53 additions & 12 deletions tests/mock_vws/test_add_target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _add_target_to_vws(
*,
vws_client: VWS,
data: dict[str, Any],
content_type: str = "application/json",
content_type: str,
) -> Response:
"""Return a response from a request to the endpoint to add a target.

Expand Down Expand Up @@ -195,7 +195,11 @@ def test_missing_data(
data.pop(data_to_remove)

with pytest.raises(expected_exception=FailError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)

assert_vws_failure(
response=exc.value.response,
Expand Down Expand Up @@ -233,7 +237,11 @@ def test_width_invalid(
}

with pytest.raises(expected_exception=FailError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)

assert_vws_failure(
response=exc.value.response,
Expand Down Expand Up @@ -343,10 +351,18 @@ def test_name_invalid(

if status_code == HTTPStatus.INTERNAL_SERVER_ERROR:
with pytest.raises(expected_exception=ServerError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)
else:
with pytest.raises(expected_exception=FailError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)

assert_vws_failure(
response=exc.value.response,
Expand Down Expand Up @@ -573,7 +589,11 @@ def test_not_base64_encoded_processable(
}

with pytest.raises(expected_exception=BadImageError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)

assert_vws_failure(
response=exc.value.response,
Expand All @@ -600,7 +620,11 @@ def test_not_base64_encoded_not_processable(
}

with pytest.raises(expected_exception=FailError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)

assert_vws_failure(
response=exc.value.response,
Expand Down Expand Up @@ -648,7 +672,11 @@ def test_invalid_type(
}

with pytest.raises(expected_exception=FailError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)

assert_vws_failure(
response=exc.value.response,
Expand Down Expand Up @@ -749,7 +777,9 @@ def test_not_set(
"image": image_data_encoded,
}

response = _add_target_to_vws(vws_client=vws_client, data=data)
response = _add_target_to_vws(
vws_client=vws_client, data=data, content_type="application/json"
)
response_json = json.loads(s=response.text)
target_id = response_json["target_id"]
target_details = vws_client.get_target_record(target_id=target_id)
Expand All @@ -774,7 +804,9 @@ def test_set_to_none(
"active_flag": None,
}

response = _add_target_to_vws(vws_client=vws_client, data=data)
response = _add_target_to_vws(
vws_client=vws_client, data=data, content_type="application/json"
)

response_json = json.loads(s=response.text)
target_id = response_json["target_id"]
Expand Down Expand Up @@ -812,7 +844,11 @@ def test_invalid_extra_data(
}

with pytest.raises(expected_exception=FailError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)

assert_vws_failure(
response=exc.value.response,
Expand Down Expand Up @@ -875,6 +911,7 @@ def test_null(
response = _add_target_to_vws(
vws_client=vws_client,
data=request_data,
content_type="application/json",
)

assert_success(response=response)
Expand Down Expand Up @@ -902,7 +939,11 @@ def test_invalid_type(
}

with pytest.raises(expected_exception=FailError) as exc:
_add_target_to_vws(vws_client=vws_client, data=data)
_add_target_to_vws(
vws_client=vws_client,
data=data,
content_type="application/json",
)

assert_vws_failure(
response=exc.value.response,
Expand Down
11 changes: 10 additions & 1 deletion tests/mock_vws/test_update_target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def _update_target(
vws_client: VWS,
data: dict[str, Any],
target_id: str,
content_type: str = "application/json",
content_type: str,
) -> Response:
"""Make a request to the endpoint to update a target.

Expand Down Expand Up @@ -160,6 +160,7 @@ def test_no_fields_given(
vws_client=vws_client,
data={},
target_id=target_id,
content_type="application/json",
)

assert_vws_response(
Expand Down Expand Up @@ -203,6 +204,7 @@ def test_invalid_extra_data(
vws_client=vws_client,
data={"extra_thing": 1},
target_id=target_id,
content_type="application/json",
)

assert_vws_failure(
Expand Down Expand Up @@ -239,6 +241,7 @@ def test_width_invalid(
vws_client=vws_client,
data={"width": width},
target_id=target_id,
content_type="application/json",
)

assert_vws_failure(
Expand Down Expand Up @@ -321,6 +324,7 @@ def test_invalid(
vws_client=vws_client,
data={"active_flag": desired_active_flag},
target_id=target_id,
content_type="application/json",
)

assert_vws_failure(
Expand Down Expand Up @@ -375,6 +379,7 @@ def test_invalid_type(
vws_client=vws_client,
data={"application_metadata": invalid_metadata},
target_id=target_id,
content_type="application/json",
)

assert_vws_failure(
Expand Down Expand Up @@ -538,6 +543,7 @@ def test_name_invalid(
vws_client=vws_client,
data={"name": name},
target_id=target_id,
content_type="application/json",
)

assert_vws_failure(
Expand Down Expand Up @@ -759,6 +765,7 @@ def test_not_base64_encoded_processable(
vws_client=vws_client,
data={"image": not_base64_encoded_processable},
target_id=target_id,
content_type="application/json",
)

assert_vws_failure(
Expand Down Expand Up @@ -787,6 +794,7 @@ def test_not_base64_encoded_not_processable(
vws_client=vws_client,
data={"image": not_base64_encoded_not_processable},
target_id=target_id,
content_type="application/json",
)

assert_vws_failure(
Expand Down Expand Up @@ -835,6 +843,7 @@ def test_invalid_type(
vws_client=vws_client,
data={"image": invalid_type_image},
target_id=target_id,
content_type="application/json",
)

assert_vws_failure(
Expand Down
Loading