Skip to content

[v0.47.0-rh] fix(aws cloudwatch): emit component_sent_bytes_total through Driver to ensure component labels#284

Open
Clee2691 wants to merge 1 commit into
ViaQ:v0.47.0-rhfrom
Clee2691:LOG-7893
Open

[v0.47.0-rh] fix(aws cloudwatch): emit component_sent_bytes_total through Driver to ensure component labels#284
Clee2691 wants to merge 1 commit into
ViaQ:v0.47.0-rhfrom
Clee2691:LOG-7893

Conversation

@Clee2691

@Clee2691 Clee2691 commented Jul 16, 2026

Copy link
Copy Markdown

Description

  • Suppress transport-level AwsBytesSent for CloudWatch to eliminate duplicate component_sent_bytes_total metrics without component labels
  • Route byte reporting through the Driver, which runs within the component tracing span
  • Add generic .label(key, value) builder on Driver so sinks can attach extra metric labels; CloudWatch uses it to add region
  • Add an integration test for the Cloudwatch sink.

Links

JIRA: https://redhat.atlassian.net/browse/LOG-7893

/cc @vparfonov
/assign @jcantrill

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: dba65d3f-f5f6-4ca7-9db5-1042d18b61fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jcantrill

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Clee2691 Clee2691 changed the title fix(aws cloudwatch): emit component_sent_bytes_total through Driver to ensure component labels [v0.47.0-rh] fix(aws cloudwatch): emit component_sent_bytes_total through Driver to ensure component labels Jul 16, 2026
@Clee2691

Copy link
Copy Markdown
Author

/retest

1 similar comment
@Clee2691

Copy link
Copy Markdown
Author

/retest

@Clee2691

Copy link
Copy Markdown
Author

/hold

@Clee2691

Copy link
Copy Markdown
Author

/hold cancel

@Clee2691

Copy link
Copy Markdown
Author

/test all

@Clee2691

Copy link
Copy Markdown
Author

/hold

@Clee2691

Copy link
Copy Markdown
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants