Fix segfault caused by linking both libncurses and libncursesw - #210
Open
carecodeconnect wants to merge 1 commit into
Open
Fix segfault caused by linking both libncurses and libncursesw#210carecodeconnect wants to merge 1 commit into
carecodeconnect wants to merge 1 commit into
Conversation
Removed the redundant AC_CHECK_LIB(ncurses, main) call that unconditionally added -lncurses to LIBS. With the ncursesw-preferring check already appending -lncursesw, the linker ended up with both libraries linked simultaneously. Since they export identical symbols, this caused runtime symbol conflicts and a segfault. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AC_CHECK_LIB(ncurses, main)call that unconditionally added-lncursestoLIBS-lncursesw, the linker ended up with both libraries linked simultaneously (LIBS = -lncurses -lncursesw)Test plan
autoreconf -fi && ./configure && makeLIBSin the generated Makefile contains only one ncurses library (e.g.-lncursesw)./cmatrixand confirm it no longer segfaults🤖 Generated with Claude Code