Filter PRs by user in isFirstPullRequest - #402
Open
michen00 wants to merge 2 commits into
Open
Conversation
The isFirstPullRequest function was checking ALL PRs in the repo instead of only the current user's PRs. This caused everyone to be identified as a new contributor in repos with issues disabled (since isFirstIssue returns true when no issues exist). Now isFirstPullRequest filters PRs by user login, matching the behavior of isFirstIssue. Closes actions#369 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
michen00
marked this pull request as draft
January 24, 2026 19:00
michen00
marked this pull request as ready for review
January 24, 2026 19:03
michen00
changed the title
michen00
marked this pull request as draft
January 24, 2026 19:09
For issue events, only check isFirstIssue(). For PR events, only check isFirstPullRequest(). This fixes the case where repos with issues disabled would mark everyone as a new contributor (since isFirstIssue returns true when no issues exist). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
michen00
marked this pull request as ready for review
January 24, 2026 19:14
Author
|
Hi, just checking in on this PR—happy to make any changes or provide more context if helpful. |
Forge-Atlas-founder
approved these changes
May 7, 2026
2 tasks
Author
|
Related: #410 |
Author
|
@ncalteen Hiya, just checking in on this PR—happy to make any changes or provide more context if helpful. |
LapNik
reviewed
Aug 7, 2026
Comment on lines
+40
to
+44
| // Check if this is the user's first contribution of the relevant type. | ||
| if (isIssue && !(await isFirstIssue(octokit))) | ||
| return core.info('Skipping...Not First Issue') | ||
| if (isPullRequest && !(await isFirstPullRequest(octokit))) | ||
| return core.info('Skipping...Not First Pull Request') |
There was a problem hiding this comment.
Checking typed contributions is a valid use case, but so is checking untyped contributions, I think. Maybe an issue comment should not be created if a user is familiar enough with the repository to have authored a PR.
In my opinion the name of the action first-interaction implies any contribution. The action could have subdirectories like actions/first-interaction/first-pr and actions/first-interaction/first-issue for checking specific types.
Suggested change
| // Check if this is the user's first contribution of the relevant type. | |
| if (isIssue && !(await isFirstIssue(octokit))) | |
| return core.info('Skipping...Not First Issue') | |
| if (isPullRequest && !(await isFirstPullRequest(octokit))) | |
| return core.info('Skipping...Not First Pull Request') | |
| // Check if this is the user's first contribution. | |
| if (!(await isFirstIssue(octokit) && await isFirstPullRequest(octokit))) | |
| return core.info('Skipping...Not First Contribution') |
Though, maybe clearer function names would be something like userHasAuthoredPullRequestsPreviously and userHasReportedIssuesPreviously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isFirstPullRequest()to filter PRs by the current user's loginisFirstIssue()isFirstPullRequest()isFirstIssuereturns true when no issues exist)Test plan
Fixes #369.