install: route kind component deploys through the overlays - #703
Open
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Open
install: route kind component deploys through the overlays#703NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Conversation
--deploy-atenet and --deploy-ate-apiserver applied base manifests directly, skipping the kind overlay's OTel env patches — components silently exported telemetry to the GKE-only collector address. All per-component deploys now share component_manifests(), the root kind overlay composes the component overlays so each patch exists exactly once, and hack/verify/kind-overlays.sh guards the routing, the render equivalence, and the per-container env values. Fixes agent-substrate#702.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #702
Summary
--deploy-atenetand--deploy-ate-apiserverapplied base manifests directly, skipping the kind overlay's OTel env patches, so components deployed through those flags silently exported telemetry to the GKE-only collector address. They now route through per-component kind overlays the way--deploy-ateletalready does, with the root kind overlay composing the three so each patch exists in exactly one place.hack/verify/kind-overlays.sh(picked up byverify-all.sh) guards the routing, the render equivalence, and the per-container env values.Test plan
Pre/post-refactor full kind renders are byte-identical across all 57 resources.
Six negative injections each fail the verifier (helper bypassed, container renamed, env values changed or deleted, duplicate patch re-added at root).
Real kind cluster:
--deploy-atenetlands the otel-system endpoint without manual intervention; the metrics e2e suite went from a 120s timeout to a sub-second pass.bash -n,hack/verify/shellcheck.sh, andhack/verify/boilerplate.shpass.Tests pass
Appropriate changes to documentation are included in the PR (none needed)