feat: Build Airbyte Protocol js-schema files for use in schemastore - #64
Open
Evan Tahler (evantahler) wants to merge 1 commit into
Open
feat: Build Airbyte Protocol js-schema files for use in schemastore#64Evan Tahler (evantahler) wants to merge 1 commit into
Evan Tahler (evantahler) wants to merge 1 commit into
Conversation
Evan Tahler (evantahler)
requested a review
from Aaron ("AJ") Steers (aaronsteers)
February 2, 2024 02:53
Contributor
Author
|
AJ - I totally forgot about this. Are you still interested in have SchemaStore entries for the Airbyte Protocol? I think this mostly works... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds the creation of both 'latest' and versioned JS versions of the Airbyte Protocol for use with https://www.schemastore.org.
./protocol-models/bin/generate-schemastore-docker.shlocally to try it/airbyte-protocol/jsonschema/latest/airbyte_protocol.json/airbyte-protocol/jsonschema/{version}/airbyte_protocol.jsonpull-request-publishwill run this new command when the bot creates a new PR (e.g.) for a version bump. This lets the PR reviewer see the changes, and we won't be writing directly to the main branch of the repo.These changes in aggregate allow for a simple default schematore entry (e.g.) with the following content, once we merge this: