provider: add support for na-south-1 region validation - #10105
Merged
Conversation
Add na-south-1 to the ValidRegions list so users no longer need to set skip_region_validation=true when using this region. Also update the region definitions test to assert the new region is present in ValidRegions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
na-south-1to theValidRegionslist so users targeting this region no longer hit:and no longer need to set
skip_region_validation = true.The region is live — its service endpoints resolve (
ecs.na-south-1.aliyuncs.com,vpc.na-south-1.aliyuncs.com,oss-na-south-1.aliyuncs.com).The region definitions unit test is updated to assert the new constant is present in
ValidRegions.Fixes #10100