fix: Username exists when creating new user - #13
Merged
Conversation
ItsAbhinavM
self-requested a review
April 15, 2026 16:58
ItsAbhinavM
requested changes
Apr 15, 2026
ItsAbhinavM
left a comment
ItsAbhinavM
left a comment
Member
There was a problem hiding this comment.
The current work looks good. I see that for auth there are functions like login for existing users and google_verify for new users. How is login for google auth users handled, is there any endpoint for that ?
- Also a suggestion that the function name
complete_profileseems a bit confusing if you are registering new users in that function. Renaming it togoogle_registerwould be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #11
Description
When a new user registers using OAuth, they are redirected to complete their profile and set a username. This PR checks if a username already exists in the db.