feat(@angular/build): migrate i18n inliner to oxc-parser + magic-string#33601
Merged
Conversation
angular-robot
Bot
added
detected: feature
clydin
marked this pull request as ready for review
July 17, 2026 22:51
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces Babel with OXC and Magic-String in the i18n inliner worker to optimize translation inlining. Feedback is provided regarding template literal reconstruction, where carriage returns could be normalized to line feeds and corrupt translations; a suggestion is made to use JSON.stringify for robust escaping.
This refactors the i18n translation and locale inlining in the ESBuild pipeline to use `oxc-parser` and `magic-string` instead of `@babel/core`. By using the lightweight AST and precise token spans provided by OXC, we are able to perform `$localize` inlining and locale name replacements via targeted `magic-string` overwrites in-place. This completely removes the dependency on `@babel/core` and the custom/upstream Babel plugins in the worker, yielding faster startup times and significant compile-time speedups for localized builds.
clydin
force-pushed
the
feat/i18n-oxc-transformer
branch
from
July 17, 2026 22:56
cc6d3a3 to
29fb055
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Jul 20, 2026
alan-agius4
added
action: merge
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the i18n translation and locale inlining in the ESBuild pipeline to use
oxc-parserandmagic-stringinstead of@babel/core.By using the lightweight AST and precise token spans provided by OXC, we are able to perform
$localizeinlining and locale name replacements via targetedmagic-stringoverwrites in-place. This completely removes the dependency on@babel/coreand the custom/upstream Babel plugins in the worker, yielding faster startup times and significant compile-time speedups for localized builds.