-
Notifications
You must be signed in to change notification settings - Fork 4.1k
cputime optimize for arm64 #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dwh110
wants to merge
1
commit into
apache:master
Choose a base branch
from
dwh110:cputime_opt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−11
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -265,7 +265,7 @@ inline uint64_t clock_cycles() { | |
| #error "unsupported arch" | ||
| #endif | ||
| } | ||
| extern int64_t read_invariant_cpu_frequency(); | ||
|
|
||
| // Be positive iff: | ||
| // 1 Intel x86_64 CPU (multiple cores) supporting constant_tsc and | ||
| // nonstop_tsc(check flags in /proc/cpuinfo) | ||
|
|
@@ -279,7 +279,7 @@ extern int64_t invariant_cpu_freq; | |
| // note: Inlining shortens time cost per-call for 15ns in a loop of many | ||
| // calls to this function. | ||
| inline int64_t cpuwide_time_ns() { | ||
| #if !defined(BAIDU_INTERNAL) | ||
| #if !defined(BAIDU_INTERNAL) && !defined(__aarch64__) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a macro switch, such as BUTIL_USE_CPU_FREQUENCY, to let users choose whether to enable it instead of enabling it by default on arm64. |
||
| // nearly impossible to get the correct invariant cpu frequency on | ||
| // different CPU and machines. CPU-ID rarely works and frequencies | ||
| // in "model name" and "cpu Mhz" are both unreliable. | ||
|
|
@@ -298,14 +298,9 @@ inline int64_t cpuwide_time_ns() { | |
| const uint64_t remain = tsc % cpu_freq; | ||
| // TODO: should be OK until CPU's frequency exceeds 16GHz. | ||
| return remain * 1000000000L / cpu_freq + sec * 1000000000L; | ||
| } else if (!cpu_freq) { | ||
| } else { | ||
| // Lack of necessary features, return system-wide monotonic time instead. | ||
| return monotonic_time_ns(); | ||
|
dwh110 marked this conversation as resolved.
|
||
| } else { | ||
| // Use a thread-unsafe method(OK to us) to initialize the freq | ||
| // to save a "if" test comparing to using a local static variable | ||
| detail::invariant_cpu_freq = detail::read_invariant_cpu_frequency(); | ||
| return cpuwide_time_ns(); | ||
| } | ||
| #endif // defined(BAIDU_INTERNAL) | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.