fix(examples): bound image telephone downloads - #879
Open
Ghraven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The image-telephone examples download generated image URLs with
requests.get(image_url).content. Without a timeout, the examples can hang indefinitely if the image host stalls. They also write the response body without checking HTTP status, so an error response can be saved as if it were an image.Before / after
Before, both the base image-telephone example and the Hamilton integration variant used unbounded image downloads and did not call
raise_for_status().After, both examples use a 30 second image download timeout and call
raise_for_status()before writing the image bytes. Successful downloads keep the same behavior.Verification
python -m py_compile examples\image-telephone\application.py examples\integrations\hamilton\image-telephone\application.pygit diff --check