Skip to content

Addition of type and VM filter in the backup listing API #13644

Open
GeanJair wants to merge 1 commit into
apache:mainfrom
scclouds:add-type-and-vm-filter-to-backup-listing
Open

Addition of type and VM filter in the backup listing API #13644
GeanJair wants to merge 1 commit into
apache:mainfrom
scclouds:add-type-and-vm-filter-to-backup-listing

Conversation

@GeanJair

Copy link
Copy Markdown
Contributor

Description

Currently, the listBackups API does not allow listing backups based on their type. Changes have been made to the API to allow backups to be listed informing a specific type. In addition, although the API already supports the filtering of backups by VM, support for this parameter had not been added to the GUI. Therefore, the GUI backup filter has been extended to support the search by both type and VM.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Example of a listBackups API call

type-full-api-call

listBackups API call when filtering by a non-existent type

non-existent-type-api-call

Filtering field in the GUI

base-ui

filter-by-vm

filter-by-type

filter-by-unavailable-type

How Has This Been Tested?

  • I checked the possibility of filtering backups by type.
  • I checked the possibility of filtering backups by VM.
  • I checked the response generated when attempting to pass a non-existent type or VM via CloudMonkey.
  • I checked the response generated when attempting to pass a non-existent type or VM via the browser URL.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm at first sight, but does backupType have a backing enum type that validation should happen against?

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.64%. Comparing base (75748a5) to head (f324f5c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...dstack/api/command/user/backup/ListBackupsCmd.java 0.00% 3 Missing ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13644      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19791       -1     
============================================
  Files          6368     6368              
  Lines        575107   575111       +4     
  Branches      70370    70370              
============================================
- Hits         113016   113007       -9     
- Misses       449808   449817       +9     
- Partials      12283    12287       +4     
Flag Coverage Δ
uitests 3.41% <ø> (+<0.01%) ⬆️
unittests 20.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants