Addition of type and VM filter in the backup listing API #13644
Addition of type and VM filter in the backup listing API #13644GeanJair wants to merge 1 commit into
Conversation
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm at first sight, but does backupType have a backing enum type that validation should happen against?
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13644 +/- ##
============================================
- Coverage 19.65% 19.64% -0.01%
+ Complexity 19792 19791 -1
============================================
Files 6368 6368
Lines 575107 575111 +4
Branches 70370 70370
============================================
- Hits 113016 113007 -9
- Misses 449808 449817 +9
- Partials 12283 12287 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18624 |
Description
Currently, the
listBackupsAPI does not allow listing backups based on their type. Changes have been made to the API to allow backups to be listed informing a specific type. In addition, although the API already supports the filtering of backups by VM, support for this parameter had not been added to the GUI. Therefore, the GUI backup filter has been extended to support the search by both type and VM.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Example of a
listBackupsAPI calllistBackupsAPI call when filtering by a non-existent typeFiltering field in the GUI
How Has This Been Tested?