Fix ExecutorService leak in WS-RM oneway tests#2963
Merged
Conversation
DeliveryAssuranceOnewayTest and MessageCallbackOnewayTest create ExecutorService instances via Executors.newSingleThreadExecutor() but never shut them down. The leaked non-daemon threads prevent clean test completion, causing intermittent timeouts in CI (~95-100s for DeliveryAssurance, ~75s for MessageCallback). Track the ExecutorService and shut it down in tearDown() with a 10-second grace period before forceful termination. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
marked this pull request as ready for review
March 12, 2026 18:01
Contributor
|
I tried this locally and it doesn't seem to solve the flakiness of the tests |
coheigea
approved these changes
Jul 24, 2026
coheigea
left a comment
coheigea
left a comment
Contributor
There was a problem hiding this comment.
It seems to help somewhat, even though it doesn't fix all the issues, so let's just merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeliveryAssuranceOnewayTestandMessageCallbackOnewayTestcreateExecutorServiceinstances viaExecutors.newSingleThreadExecutor()in their*AsyncExecutortest methods but never shut them downExecutorServicein an instance field and shut it down intearDown()with a 10-second grace period before forceful terminationTest plan
DeliveryAssuranceOnewayTestandMessageCallbackOnewayTestcomplete within their 60s timeout🤖 Generated with Claude Code