[flink] Support batch delete and update in flink sink - #3863
Open
loserwang1024 wants to merge 2 commits into
Open
[flink] Support batch delete and update in flink sink#3863loserwang1024 wants to merge 2 commits into
loserwang1024 wants to merge 2 commits into
Conversation
naivedogger
approved these changes
Aug 6, 2026
naivedogger
left a comment
naivedogger
left a comment
Contributor
There was a problem hiding this comment.
Thanks @loserwang1024 for the pr! Overall LGTM, just left one minor suggestion.
| "+I[2, 2001, " + partition2 + "]"), | ||
| true); | ||
|
|
||
| tBatchEnv.executeSql("DELETE FROM " + t2 + " WHERE a = 1").await(); |
Contributor
There was a problem hiding this comment.
This test uses WHERE a = 1 on a table partitioned by c, so partition pruning is not covered. Since the issue explicitly mentions partition-filter deletes like DELETE FROM orders WHERE dt = '2026-07-21', would it be possible to also add a partition-only filter case (e.g., WHERE c = '<partition>') to cover that path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3724
Brief change log
Tests
API and Format
Documentation