[SYSTEMDS-3959] Report an error when a federated worker cannot bind its port - #2586
Open
gaturchenko wants to merge 1 commit into
Open
[SYSTEMDS-3959] Report an error when a federated worker cannot bind its port#2586gaturchenko wants to merge 1 commit into
gaturchenko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command
systemds WORKER 80505terminated silently with exit code 0. There are 2 causes:-w <port>FederatedWorker.run()captured every exception in a catch-all. The same held for occupied and reserved ports, and for the-fedMonitoringbackendThe following changes were implemented:
PortUtils(new): shared port validation plusexplainBindFailure, which turns terse socket errors into messages naming the port and the cause.DMLOptions:-wand-fedMonitoringreject non-integers and ports outside[1, 65535]. A missing (optional)-wargument now falls back to the default port instead of throwingNumberFormatException.FederatedWorker/FederatedMonitoringServer: reject out-of-range ports upfront, warn on reserved ports (< 1024), and throw bind failures asDMLRuntimeExceptionafter logging.bin/systemds: the duplicatedWORKER/FEDMONITORINGcheck is now onecheckPortfunction with a range check andexit 1. Previously, an error was printed and the JVM was launched regardless.