Skip to content
This repository was archived by the owner on Jul 16, 2026. It is now read-only.

Correct some problems - #2

Open
Servuc wants to merge 2 commits into
archivealvarolorentedev:masterfrom
snowtrackers:master
Open

Correct some problems#2
Servuc wants to merge 2 commits into
archivealvarolorentedev:masterfrom
snowtrackers:master

Conversation

@Servuc

@Servuc Servuc commented Sep 6, 2017

Copy link
Copy Markdown

Hi,

I've made few change :

  • First, change regex : Actually, I can't use this lib because some urls in results contains french text like : activites_sportives, that doesn't match : sport_session;
  • Second, after correct regex, I can't get detail for one workout because session.uid give lot of information that doesn't match final url, so I replace it by session.id in url making.

Have a good day 🐻
Servuc

@alvarolorentedev

Copy link
Copy Markdown
Collaborator

i will review it :), and get back to you, thanks for the pull request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants