Skip to content

Skip wrong dotenv package - #258

Open
jamesmyatt wants to merge 1 commit into
arpanghosh8453:mainfrom
jamesmyatt:patch-1
Open

Skip wrong dotenv package#258
jamesmyatt wants to merge 1 commit into
arpanghosh8453:mainfrom
jamesmyatt:patch-1

Conversation

@jamesmyatt

@jamesmyatt jamesmyatt commented May 17, 2026

Copy link
Copy Markdown

"dotenv" is the wrong "dotenv" pypi package. Correct one is "python-dotenv". See https://github.com/pedroburon/dotenv.

@arpanghosh8453

Copy link
Copy Markdown
Owner

@jamesmyatt Checked and acknowledged. You are right. I have a dew questions.

  1. Are they in functional parity? id this a drop in replacement?
  2. Did you run UV sync to update the uv.lock file to update the dependencies? I am confused because I don't see the version specific hash added to the list for the python-dotenv
  3. Have you built the docker image (or just using the script in a venv) with the updated requirements and tested the script functionality?

Thank you again for helping me with keeping this project up to date.

@jamesmyatt

jamesmyatt commented May 17, 2026

Copy link
Copy Markdown
Author

"dotenv" 0.9.9 now just an empty package with "python-dotenv" as a dependency. So you're already using the right package but the dependency specification is wrong. You can see this in the uv.lock diff (which I created with uv lock). I pinned the version that's already in the lock file (current one is 1.2.2 if you want to update). So everything should work just the same.

@arpanghosh8453

Copy link
Copy Markdown
Owner

@jamesmyatt awesome! I can merge this right away if you can do the testing real quick, as you already have the updated code locally. Otherwise this will wait for merging until I have time to test it (although I understand this is just a change of shell package)

@jamesmyatt

Copy link
Copy Markdown
Author

I haven't got round to setting up the script. I'm just reviewing it before that. But it certainly still builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants