Add Port Access CDP/LLDP device classification group modules - #221
Open
ed6869 wants to merge 1 commit into
Open
Conversation
Add aoscx_port_access_cdp_group and aoscx_port_access_lldp_group to manage Port Access device classification groups (system/port_access_cdp_groups, system/port_access_lldp_groups). A group is an ordered list of match entries; CDP entries match platform, software_version and voice_vlan_query_value, LLDP entries match system_description, system_name, vendor_oui and vendor_oui_subtype. The supplied entries fully replace the existing ones. The shared logic lives in module_utils/port_access_device_group.py. Validated live on a CX6300 (FL.10.17, REST latest): create, idempotency, per-entry update and delete. Fixes aruba#220 Signed-off-by: ed6869 <ed6869@mail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two modules to manage Port Access device classification groups, which classify connected devices by the attributes they advertise through CDP/LLDP and are referenced by device profiles:
aoscx_port_access_cdp_group—system/port_access_cdp_groups; entries matchplatform,software_version,voice_vlan_query_value.aoscx_port_access_lldp_group—system/port_access_lldp_groups; entries matchsystem_description,system_name,vendor_oui,vendor_oui_subtype.Each group is an ordered list of match entries indexed by
sequence_number; the supplied entries fully replace the existing ones. Shared logic lives inmodule_utils/port_access_device_group.py. Supports check mode.Testing
Validated live on a CX6300 (FL.10.17, REST latest): create, idempotency, per-entry update and delete of both CDP and LLDP groups.
show running-configconfirmed the expectedport-access cdp-group/lldp-groupblocks with theirseq N match ...entries. Sanity (pep8, pylint, validate-modules) passes.Fixes #220
Depends on SDK PR aruba/pyaoscx#113