Persist breakpoints and add go-to-address to the debugger - #59
Merged
Conversation
Breakpoints ride the existing preserve()/restore() localStorage path, so they survive reloads alongside EEPROM and RTC state. Persisting them surfaced a chicken-and-egg flaw: halting at a breakpoint stops the CPU before the instruction executes, so on a fresh classification map the breakpoint's own byte never becomes code — and the marker only rendered on code lines, hiding exactly the breakpoints that fire. Markers now render on any line whose byte range contains a breakpoint (hex rows included), and double-clicking such a line clears them; setting new breakpoints stays code-line-only. The toolbar gains a go-to-address field (hex, 0x/h decorations accepted): jumping turns follow-PC off and scrolls by exact offset — rows are fixed-height, and scrollToIndex works from estimates that can land a row short. The system instance is also exposed as window.minimon for console debugging. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debugger follow-ups from the rewrite:
preserve()/restore()localStorage path (alongside EEPROM/RTC)0x/hdecorations accepted): jumping unfollows the PC and scrolls by exact offset (fixed-height rows;scrollToIndexestimates can land a row short)window.minimonexposes the system instance for console debuggingVerification
Headless, in-context reloads:
live: [3388]restored,●rendered on the halted-at row even though it classifies as hex)goto 0000→ unfollows, scrollTop 0, first row0000;goto 0x2100lands the target in view while runningnpm run check+vite buildclean🤖 Generated with Claude Code