Skip to content

Return a float where promised for function edd_get_payment_amount - #9604

Open
StephenGravitt wants to merge 10000 commits into
awesomemotive:mainfrom
StephenGravitt:hotfix/return-float-as-promised
Open

Return a float where promised for function edd_get_payment_amount#9604
StephenGravitt wants to merge 10000 commits into
awesomemotive:mainfrom
StephenGravitt:hotfix/return-float-as-promised

Conversation

@StephenGravitt

Copy link
Copy Markdown
  • Doc block indicates float should be returned
  • If order_id param is empty, function returns an empty string
  • fix replaces empty string with zeroed out float value (0.00)

Fixes awesomemotive/easy-digital-downloads-pro#81

Proposed Changes:

  1. replace empty string with zeroed out float value (0.00) to uphold documentation and offer more consistency

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants