Fix customer email search missing primary-email-only customers - #9831
Open
anisur2805 wants to merge 1 commit into
Open
Fix customer email search missing primary-email-only customers#9831anisur2805 wants to merge 1 commit into
anisur2805 wants to merge 1 commit into
Conversation
Searching Downloads > Customers by a full email address only queried the edd_customer_email_addresses table. A customer whose email is stored in edd_customers.email but has no matching row in that table returned no results, even though a partial/domain search found them. Add a fallback that runs only when the email-addresses lookup returns nothing: look the customer up by the primary email column via get_item_by( 'email', ... ). This matches the customers table directly, unlike the Customer query 'email' argument which parse_query_for_emails() reroutes to the email addresses table. Fixes awesomemotive#9825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching Downloads > Customers by a full email address only queried the edd_customer_email_addresses table. A customer whose email is stored in edd_customers.email but has no matching row in that table returned no results, even though a partial/domain search found them.
Add a fallback that runs only when the email-addresses lookup returns nothing: look the customer up by the primary email column via get_item_by( 'email', ... ). This matches the customers table directly, unlike the Customer query 'email' argument which parse_query_for_emails() reroutes to the email addresses table.
Fixes #9825