feat(files): attach_to on upload_file - #48
Draft
gauravmm wants to merge 1 commit into
Draft
Conversation
upload_file returned a file_upload_id and nothing in the server said what
to do with it. Placing the file took a second call with raw children JSON
whose shape appears in no schema or example.
attach_to: { block_id, caption?, position? } appends the block in the same
call. The block type follows the content type: image, video, audio, pdf,
else file.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YM3ZVWH22UzzTTbbkoJw9P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upload_filereturned afile_upload_idand nothing in the server said what to do with it. Placing the file took a second call with rawchildrenJSON whose shape appears in no schema or example.attach_to: { block_id, caption?, position? }appends the block in the same call. The block type follows the content type: image, video, audio, pdf, else file.Adds tests that fail without the fix. Suite stays green.
Note for a reviewer:
attach_to.block_idis a bare string here, because this branch was cut beforefeat/accept-notion-urls-as-ids. If both land,block_idneedsnotionId()in the same pass.